Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Menu
Open sidebar
佳 邓
Gitlab4j Api
Commits
a80780c7
Unverified
Commit
a80780c7
authored
Apr 11, 2021
by
Gautier de Saint Martin Lacaze
Committed by
GitHub
Apr 11, 2021
Browse files
Merge pull request #654 from esep/prevent_nsee
Prevent NoSuchElementException from PagerSpliterator class
parents
7c0cf5e8
d356278e
Changes
2
Hide whitespace changes
Inline
Side-by-side
src/main/java/org/gitlab4j/api/PagerSpliterator.java
View file @
a80780c7
...
@@ -30,8 +30,10 @@ class PagerSpliterator<T> implements Spliterator<T> {
...
@@ -30,8 +30,10 @@ class PagerSpliterator<T> implements Spliterator<T> {
return
true
;
return
true
;
}
else
if
(
pager
.
hasNext
())
{
}
else
if
(
pager
.
hasNext
())
{
elements
=
pager
.
next
().
iterator
();
elements
=
pager
.
next
().
iterator
();
action
.
accept
(
elements
.
next
());
if
(
elements
.
hasNext
())
{
return
true
;
action
.
accept
(
elements
.
next
());
return
true
;
}
}
}
return
false
;
return
false
;
}
}
...
...
src/test/java/org/gitlab4j/api/PagerSpliteratorTest.java
View file @
a80780c7
...
@@ -46,6 +46,16 @@ public class PagerSpliteratorTest {
...
@@ -46,6 +46,16 @@ public class PagerSpliteratorTest {
assertFalse
(
success
);
assertFalse
(
success
);
}
}
@Test
public
void
shouldReturnFalseIfNextPagerItemMissing
()
{
when
(
pager
.
hasNext
()).
thenReturn
(
true
);
when
(
pager
.
next
()).
thenReturn
(
Collections
.
emptyList
());
boolean
success
=
pagerSpliterator
.
tryAdvance
(
System
.
out
::
println
);
assertFalse
(
success
);
}
@Test
@Test
public
void
shouldThrowNullPointerExceptionWhenActionIsMissing
()
{
public
void
shouldThrowNullPointerExceptionWhenActionIsMissing
()
{
...
@@ -75,4 +85,4 @@ public class PagerSpliteratorTest {
...
@@ -75,4 +85,4 @@ public class PagerSpliteratorTest {
assertArrayEquals
(
new
Integer
[]{
1
,
2
,
3
,
4
,
5
},
elements
);
assertArrayEquals
(
new
Integer
[]{
1
,
2
,
3
,
4
,
5
},
elements
);
}
}
}
}
\ No newline at end of file
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment