Unverified Commit a80780c7 authored by Gautier de Saint Martin Lacaze's avatar Gautier de Saint Martin Lacaze Committed by GitHub
Browse files

Merge pull request #654 from esep/prevent_nsee

Prevent NoSuchElementException from PagerSpliterator class
parents 7c0cf5e8 d356278e
......@@ -30,8 +30,10 @@ class PagerSpliterator<T> implements Spliterator<T> {
return true;
} else if (pager.hasNext()) {
elements = pager.next().iterator();
action.accept(elements.next());
return true;
if(elements.hasNext()) {
action.accept(elements.next());
return true;
}
}
return false;
}
......
......@@ -46,6 +46,16 @@ public class PagerSpliteratorTest {
assertFalse(success);
}
@Test
public void shouldReturnFalseIfNextPagerItemMissing() {
when(pager.hasNext()).thenReturn(true);
when(pager.next()).thenReturn(Collections.emptyList());
boolean success = pagerSpliterator.tryAdvance(System.out::println);
assertFalse(success);
}
@Test
public void shouldThrowNullPointerExceptionWhenActionIsMissing() {
......@@ -75,4 +85,4 @@ public class PagerSpliteratorTest {
assertArrayEquals(new Integer[]{1, 2, 3, 4, 5}, elements);
}
}
\ No newline at end of file
}
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment