Unverified Commit cf58df40 authored by Gautier de Saint Martin Lacaze's avatar Gautier de Saint Martin Lacaze
Browse files

Fix tests failed since ids migration from Integer to Long

parent 09ed795b
...@@ -33,14 +33,14 @@ public abstract class AbstractApi implements Constants { ...@@ -33,14 +33,14 @@ public abstract class AbstractApi implements Constants {
* Returns the project ID or path from the provided Integer, String, or Project instance. * Returns the project ID or path from the provided Integer, String, or Project instance.
* *
* @param obj the object to determine the ID or path from * @param obj the object to determine the ID or path from
* @return the project ID or path from the provided Integer, String, or Project instance * @return the project ID or path from the provided Long, String, or Project instance
* @throws GitLabApiException if any exception occurs during execution * @throws GitLabApiException if any exception occurs during execution
*/ */
public Object getProjectIdOrPath(Object obj) throws GitLabApiException { public Object getProjectIdOrPath(Object obj) throws GitLabApiException {
if (obj == null) { if (obj == null) {
throw (new RuntimeException("Cannot determine ID or path from null object")); throw (new RuntimeException("Cannot determine ID or path from null object"));
} else if (obj instanceof Integer) { } else if (obj instanceof Long) {
return (obj); return (obj);
} else if (obj instanceof String) { } else if (obj instanceof String) {
return (urlEncode(((String) obj).trim())); return (urlEncode(((String) obj).trim()));
...@@ -60,7 +60,7 @@ public abstract class AbstractApi implements Constants { ...@@ -60,7 +60,7 @@ public abstract class AbstractApi implements Constants {
} else { } else {
throw (new RuntimeException("Cannot determine ID or path from provided " + obj.getClass().getSimpleName() + throw (new RuntimeException("Cannot determine ID or path from provided " + obj.getClass().getSimpleName() +
" instance, must be Integer, String, or a Project instance")); " instance, must be Long, String, or a Project instance"));
} }
} }
...@@ -68,14 +68,14 @@ public abstract class AbstractApi implements Constants { ...@@ -68,14 +68,14 @@ public abstract class AbstractApi implements Constants {
* Returns the group ID or path from the provided Integer, String, or Group instance. * Returns the group ID or path from the provided Integer, String, or Group instance.
* *
* @param obj the object to determine the ID or path from * @param obj the object to determine the ID or path from
* @return the group ID or path from the provided Integer, String, or Group instance * @return the group ID or path from the provided Long, String, or Group instance
* @throws GitLabApiException if any exception occurs during execution * @throws GitLabApiException if any exception occurs during execution
*/ */
public Object getGroupIdOrPath(Object obj) throws GitLabApiException { public Object getGroupIdOrPath(Object obj) throws GitLabApiException {
if (obj == null) { if (obj == null) {
throw (new RuntimeException("Cannot determine ID or path from null object")); throw (new RuntimeException("Cannot determine ID or path from null object"));
} else if (obj instanceof Integer) { } else if (obj instanceof Long) {
return (obj); return (obj);
} else if (obj instanceof String) { } else if (obj instanceof String) {
return (urlEncode(((String) obj).trim())); return (urlEncode(((String) obj).trim()));
...@@ -95,7 +95,7 @@ public abstract class AbstractApi implements Constants { ...@@ -95,7 +95,7 @@ public abstract class AbstractApi implements Constants {
} else { } else {
throw (new RuntimeException("Cannot determine ID or path from provided " + obj.getClass().getSimpleName() + throw (new RuntimeException("Cannot determine ID or path from provided " + obj.getClass().getSimpleName() +
" instance, must be Integer, String, or a Group instance")); " instance, must be Long, String, or a Group instance"));
} }
} }
...@@ -110,7 +110,7 @@ public abstract class AbstractApi implements Constants { ...@@ -110,7 +110,7 @@ public abstract class AbstractApi implements Constants {
if (obj == null) { if (obj == null) {
throw (new RuntimeException("Cannot determine ID or username from null object")); throw (new RuntimeException("Cannot determine ID or username from null object"));
} else if (obj instanceof Integer) { } else if (obj instanceof Long) {
return (obj); return (obj);
} else if (obj instanceof String) { } else if (obj instanceof String) {
return (urlEncode(((String) obj).trim())); return (urlEncode(((String) obj).trim()));
...@@ -145,7 +145,7 @@ public abstract class AbstractApi implements Constants { ...@@ -145,7 +145,7 @@ public abstract class AbstractApi implements Constants {
if (obj == null) { if (obj == null) {
throw (new RuntimeException("Cannot determine ID or name from null object")); throw (new RuntimeException("Cannot determine ID or name from null object"));
} else if (obj instanceof Integer) { } else if (obj instanceof Long) {
return (obj); return (obj);
} else if (obj instanceof String) { } else if (obj instanceof String) {
return (urlEncode(((String) obj).trim())); return (urlEncode(((String) obj).trim()));
......
...@@ -642,7 +642,7 @@ public class GroupApi extends AbstractApi { ...@@ -642,7 +642,7 @@ public class GroupApi extends AbstractApi {
* @return the created Group instance * @return the created Group instance
* @throws GitLabApiException if any exception occurs * @throws GitLabApiException if any exception occurs
* @deprecated Will be removed in version 5.0, replaced by {@link #addGroup(String, String, String, Visibility, * @deprecated Will be removed in version 5.0, replaced by {@link #addGroup(String, String, String, Visibility,
* Boolean, Boolean, Integer)} * Boolean, Boolean, Long)}
*/ */
@Deprecated @Deprecated
public Group addGroup(String name, String path, String description, Boolean membershipLock, public Group addGroup(String name, String path, String description, Boolean membershipLock,
...@@ -683,7 +683,7 @@ public class GroupApi extends AbstractApi { ...@@ -683,7 +683,7 @@ public class GroupApi extends AbstractApi {
* @return the updated Group instance * @return the updated Group instance
* @throws GitLabApiException if any exception occurs * @throws GitLabApiException if any exception occurs
* @deprecated Will be removed in version 5.0, replaced by {@link #updateGroup(Object, String, String, String, * @deprecated Will be removed in version 5.0, replaced by {@link #updateGroup(Object, String, String, String,
* Visibility, Boolean, Boolean, Integer)} * Visibility, Boolean, Boolean, Long)}
*/ */
@Deprecated @Deprecated
public Group updateGroup(Object groupIdOrPath, String name, String path, String description, Boolean membershipLock, public Group updateGroup(Object groupIdOrPath, String name, String path, String description, Boolean membershipLock,
......
...@@ -140,7 +140,7 @@ public class JobApi extends AbstractApi implements Constants { ...@@ -140,7 +140,7 @@ public class JobApi extends AbstractApi implements Constants {
* @throws GitLabApiException if any exception occurs during execution * @throws GitLabApiException if any exception occurs during execution
*/ */
public List<Job> getJobsForPipeline(Object projectIdOrPath, int pipelineId) throws GitLabApiException { public List<Job> getJobsForPipeline(Object projectIdOrPath, int pipelineId) throws GitLabApiException {
Response response = get(Response.Status.OK, getDefaultPerPageParam(), Response response = get(Response.Status.OK, getDefaultPerPageParam(),
"projects", getProjectIdOrPath(projectIdOrPath), "pipelines", pipelineId, "jobs"); "projects", getProjectIdOrPath(projectIdOrPath), "pipelines", pipelineId, "jobs");
return (response.readEntity(new GenericType<List<Job>>() {})); return (response.readEntity(new GenericType<List<Job>>() {}));
} }
...@@ -466,7 +466,7 @@ public class JobApi extends AbstractApi implements Constants { ...@@ -466,7 +466,7 @@ public class JobApi extends AbstractApi implements Constants {
* @param jobId the ID to cancel job * @param jobId the ID to cancel job
* @return job instance which just canceled * @return job instance which just canceled
* @throws GitLabApiException if any exception occurs during execution * @throws GitLabApiException if any exception occurs during execution
* @deprecated replaced by {@link #cancelJob(Object, Integer)} * @deprecated replaced by {@link #cancelJob(Object, Long)}
*/ */
@Deprecated @Deprecated
public Job cancleJob(Object projectIdOrPath, Long jobId) throws GitLabApiException { public Job cancleJob(Object projectIdOrPath, Long jobId) throws GitLabApiException {
......
...@@ -24,7 +24,7 @@ public class NotesApi extends AbstractApi { ...@@ -24,7 +24,7 @@ public class NotesApi extends AbstractApi {
* @param issueIid the issue ID to get the notes for * @param issueIid the issue ID to get the notes for
* @return a list of the issues's notes * @return a list of the issues's notes
* @throws GitLabApiException if any exception occurs * @throws GitLabApiException if any exception occurs
* @deprecated As of release 4.7.0, replaced by {@link #getIssueNotes(Object, Integer)} * @deprecated As of release 4.7.0, replaced by {@link #getIssueNotes(Object, Long)}
*/ */
@Deprecated @Deprecated
public List<Note> getNotes(Object projectIdOrPath, Long issueIid) throws GitLabApiException { public List<Note> getNotes(Object projectIdOrPath, Long issueIid) throws GitLabApiException {
...@@ -42,7 +42,7 @@ public class NotesApi extends AbstractApi { ...@@ -42,7 +42,7 @@ public class NotesApi extends AbstractApi {
* @param perPage the number of notes per page * @param perPage the number of notes per page
* @return the list of notes in the specified range * @return the list of notes in the specified range
* @throws GitLabApiException if any exception occurs * @throws GitLabApiException if any exception occurs
* @deprecated As of release 4.7.0, replaced by {@link #getIssueNotes(Object, Integer, int, int)} * @deprecated As of release 4.7.0, replaced by {@link #getIssueNotes(Object, Long, int, int)}
*/ */
@Deprecated @Deprecated
public List<Note> getNotes(Object projectIdOrPath, Long issueIid, int page, int perPage) throws GitLabApiException { public List<Note> getNotes(Object projectIdOrPath, Long issueIid, int page, int perPage) throws GitLabApiException {
...@@ -59,7 +59,7 @@ public class NotesApi extends AbstractApi { ...@@ -59,7 +59,7 @@ public class NotesApi extends AbstractApi {
* @param itemsPerPage the number of notes per page * @param itemsPerPage the number of notes per page
* @return the list of notes in the specified range * @return the list of notes in the specified range
* @throws GitLabApiException if any exception occurs * @throws GitLabApiException if any exception occurs
* @deprecated As of release 4.7.0, replaced by {@link #getIssueNotes(Object, Integer, int)} * @deprecated As of release 4.7.0, replaced by {@link #getIssueNotes(Object, Long, int)}
*/ */
@Deprecated @Deprecated
public Pager<Note> getNotes(Object projectIdOrPath, Long issueIid, int itemsPerPage) throws GitLabApiException { public Pager<Note> getNotes(Object projectIdOrPath, Long issueIid, int itemsPerPage) throws GitLabApiException {
......
...@@ -1163,7 +1163,7 @@ public class ProjectApi extends AbstractApi implements Constants { ...@@ -1163,7 +1163,7 @@ public class ProjectApi extends AbstractApi implements Constants {
* @param importUrl The Import URL for the project, otherwise null * @param importUrl The Import URL for the project, otherwise null
* @return the GitLab Project * @return the GitLab Project
* @throws GitLabApiException if any exception occurs * @throws GitLabApiException if any exception occurs
* @deprecated As of release 4.2.0, replaced by {@link #createProject(String, Integer, String, Boolean, Boolean, * @deprecated As of release 4.2.0, replaced by {@link #createProject(String, Long, String, Boolean, Boolean,
* Boolean, Boolean, Visibility, Integer, String)} * Boolean, Boolean, Visibility, Integer, String)}
*/ */
@Deprecated @Deprecated
...@@ -2268,7 +2268,7 @@ public class ProjectApi extends AbstractApi implements Constants { ...@@ -2268,7 +2268,7 @@ public class ProjectApi extends AbstractApi implements Constants {
* @param issueId the internal ID of a project's issue * @param issueId the internal ID of a project's issue
* @return the specified Issue instance * @return the specified Issue instance
* @throws GitLabApiException if any exception occurs * @throws GitLabApiException if any exception occurs
* @deprecated Will be removed in version 5.0, replaced by {@link IssuesApi#getIssue(Object, Integer)} * @deprecated Will be removed in version 5.0, replaced by {@link IssuesApi#getIssue(Object, Long)}
*/ */
@Deprecated @Deprecated
public Issue getIssue(Object projectIdOrPath, Long issueId) throws GitLabApiException { public Issue getIssue(Object projectIdOrPath, Long issueId) throws GitLabApiException {
...@@ -2284,7 +2284,7 @@ public class ProjectApi extends AbstractApi implements Constants { ...@@ -2284,7 +2284,7 @@ public class ProjectApi extends AbstractApi implements Constants {
* @param projectIdOrPath the project in the form of an Long(ID), String(path), or Project instance, required * @param projectIdOrPath the project in the form of an Long(ID), String(path), or Project instance, required
* @param issueId the internal ID of a project's issue * @param issueId the internal ID of a project's issue
* @throws GitLabApiException if any exception occurs * @throws GitLabApiException if any exception occurs
* @deprecated Will be removed in version 5.0, replaced by {@link IssuesApi#deleteIssue(Object, Integer)} * @deprecated Will be removed in version 5.0, replaced by {@link IssuesApi#deleteIssue(Object, Long)}
*/ */
@Deprecated @Deprecated
public void deleteIssue(Object projectIdOrPath, Long issueId) throws GitLabApiException { public void deleteIssue(Object projectIdOrPath, Long issueId) throws GitLabApiException {
...@@ -2605,6 +2605,8 @@ public class ProjectApi extends AbstractApi implements Constants { ...@@ -2605,6 +2605,8 @@ public class ProjectApi extends AbstractApi implements Constants {
* *
* @param projectIdOrPath the project in the form of an Integer(ID), String(path), or Project instance, required * @param projectIdOrPath the project in the form of an Integer(ID), String(path), or Project instance, required
* @param inputStream the data to upload, required * @param inputStream the data to upload, required
* @param filename The filename of the file to upload
* @param mediaType unused; will be removed in the next major version
* @return a FileUpload instance with information on the just uploaded file * @return a FileUpload instance with information on the just uploaded file
* @throws GitLabApiException if any exception occurs * @throws GitLabApiException if any exception occurs
*/ */
......
...@@ -476,7 +476,7 @@ public class RunnersApi extends AbstractApi { ...@@ -476,7 +476,7 @@ public class RunnersApi extends AbstractApi {
/** /**
* Disable a specific runner from the project. It works only if the project isn't the only project associated with * Disable a specific runner from the project. It works only if the project isn't the only project associated with
* the specified runner. If so, an error is returned. Use the {@link #removeRunner(Integer)} instead. * the specified runner. If so, an error is returned. Use the {@link #removeRunner(Long)} instead.
* *
* <pre><code>GitLab Endpoint: DELETE /projects/:id/runners/:runner_id</code></pre> * <pre><code>GitLab Endpoint: DELETE /projects/:id/runners/:runner_id</code></pre>
* *
......
...@@ -9,6 +9,7 @@ import org.gitlab4j.api.utils.JacksonJson; ...@@ -9,6 +9,7 @@ import org.gitlab4j.api.utils.JacksonJson;
import com.fasterxml.jackson.annotation.JsonIgnore; import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty; import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.databind.node.IntNode;
import com.fasterxml.jackson.databind.node.LongNode; import com.fasterxml.jackson.databind.node.LongNode;
import com.fasterxml.jackson.databind.node.TextNode; import com.fasterxml.jackson.databind.node.TextNode;
import com.fasterxml.jackson.databind.node.ValueNode; import com.fasterxml.jackson.databind.node.ValueNode;
...@@ -145,7 +146,7 @@ public class Issue { ...@@ -145,7 +146,7 @@ public class Issue {
actualId = id; actualId = id;
if (actualId instanceof TextNode) { if (actualId instanceof TextNode) {
externalId = actualId.asText(); externalId = actualId.asText();
} else if (actualId instanceof LongNode) { } else if (actualId instanceof IntNode || actualId instanceof LongNode) {
this.id = actualId.asLong(); this.id = actualId.asLong();
} }
} }
......
...@@ -40,28 +40,28 @@ public class TestCommitDiscussionsApi implements Constants { ...@@ -40,28 +40,28 @@ public class TestCommitDiscussionsApi implements Constants {
@Test @Test
public void testGetCommitDiscussionsByList() throws Exception { public void testGetCommitDiscussionsByList() throws Exception {
List<Discussion> discussions = new DiscussionsApi(gitLabApi).getCommitDiscussions(1, COMMIT_SHA); List<Discussion> discussions = new DiscussionsApi(gitLabApi).getCommitDiscussions(1L, COMMIT_SHA);
assertNotNull(discussions); assertNotNull(discussions);
assertTrue(compareJson(discussions, "commit-discussions.json")); assertTrue(compareJson(discussions, "commit-discussions.json"));
} }
@Test @Test
public void testGetCommitDiscussionsByListWithMaxItems() throws Exception { public void testGetCommitDiscussionsByListWithMaxItems() throws Exception {
List<Discussion> discussions = new DiscussionsApi(gitLabApi).getCommitDiscussions(1, COMMIT_SHA, 20); List<Discussion> discussions = new DiscussionsApi(gitLabApi).getCommitDiscussions(1L, COMMIT_SHA, 20);
assertNotNull(discussions); assertNotNull(discussions);
assertTrue(compareJson(discussions, "commit-discussions.json")); assertTrue(compareJson(discussions, "commit-discussions.json"));
} }
@Test @Test
public void testGetCommitDiscussionsByPager() throws Exception { public void testGetCommitDiscussionsByPager() throws Exception {
Pager<Discussion> discussions = new DiscussionsApi(gitLabApi).getCommitDiscussionsPager(1, COMMIT_SHA, 20); Pager<Discussion> discussions = new DiscussionsApi(gitLabApi).getCommitDiscussionsPager(1L, COMMIT_SHA, 20);
assertNotNull(discussions); assertNotNull(discussions);
assertTrue(compareJson(discussions.all(), "commit-discussions.json")); assertTrue(compareJson(discussions.all(), "commit-discussions.json"));
} }
@Test @Test
public void testGetCommitDiscussionsByStream() throws Exception { public void testGetCommitDiscussionsByStream() throws Exception {
Stream<Discussion> stream = new DiscussionsApi(gitLabApi).getCommitDiscussionsStream(1, COMMIT_SHA); Stream<Discussion> stream = new DiscussionsApi(gitLabApi).getCommitDiscussionsStream(1L, COMMIT_SHA);
assertNotNull(stream); assertNotNull(stream);
List<Discussion> discussions = stream.collect(Collectors.toList()); List<Discussion> discussions = stream.collect(Collectors.toList());
assertTrue(compareJson(discussions, "commit-discussions.json")); assertTrue(compareJson(discussions, "commit-discussions.json"));
......
...@@ -39,28 +39,28 @@ public class TestEpicDiscussionsApi implements Constants { ...@@ -39,28 +39,28 @@ public class TestEpicDiscussionsApi implements Constants {
@Test @Test
public void testGetEpicDiscussionsByList() throws Exception { public void testGetEpicDiscussionsByList() throws Exception {
List<Discussion> discussions = new DiscussionsApi(gitLabApi).getEpicDiscussions(1, 1L); List<Discussion> discussions = new DiscussionsApi(gitLabApi).getEpicDiscussions(1L, 1L);
assertNotNull(discussions); assertNotNull(discussions);
assertTrue(compareJson(discussions, "epic-discussions.json")); assertTrue(compareJson(discussions, "epic-discussions.json"));
} }
@Test @Test
public void testGetEpicDiscussionsByListWithMaxItems() throws Exception { public void testGetEpicDiscussionsByListWithMaxItems() throws Exception {
List<Discussion> discussions = new DiscussionsApi(gitLabApi).getEpicDiscussions(1, 1L, 20); List<Discussion> discussions = new DiscussionsApi(gitLabApi).getEpicDiscussions(1L, 1L, 20);
assertNotNull(discussions); assertNotNull(discussions);
assertTrue(compareJson(discussions, "epic-discussions.json")); assertTrue(compareJson(discussions, "epic-discussions.json"));
} }
@Test @Test
public void testGetEpicDiscussionsByPager() throws Exception { public void testGetEpicDiscussionsByPager() throws Exception {
Pager<Discussion> discussions = new DiscussionsApi(gitLabApi).getEpicDiscussionsPager(1, 1L, 20); Pager<Discussion> discussions = new DiscussionsApi(gitLabApi).getEpicDiscussionsPager(1L, 1L, 20);
assertNotNull(discussions); assertNotNull(discussions);
assertTrue(compareJson(discussions.all(), "epic-discussions.json")); assertTrue(compareJson(discussions.all(), "epic-discussions.json"));
} }
@Test @Test
public void testGetEpicDiscussionsByStream() throws Exception { public void testGetEpicDiscussionsByStream() throws Exception {
Stream<Discussion> stream = new DiscussionsApi(gitLabApi).getEpicDiscussionsStream(1, 1L); Stream<Discussion> stream = new DiscussionsApi(gitLabApi).getEpicDiscussionsStream(1L, 1L);
assertNotNull(stream); assertNotNull(stream);
List<Discussion> discussions = stream.collect(Collectors.toList()); List<Discussion> discussions = stream.collect(Collectors.toList());
assertTrue(compareJson(discussions, "epic-discussions.json")); assertTrue(compareJson(discussions, "epic-discussions.json"));
......
...@@ -22,11 +22,11 @@ import org.junit.experimental.categories.Category; ...@@ -22,11 +22,11 @@ import org.junit.experimental.categories.Category;
/** /**
* In order for these tests to run you must set the following properties in ~/test-gitlab4j.properties * In order for these tests to run you must set the following properties in ~/test-gitlab4j.properties
* *
* TEST_NAMESPACE * TEST_NAMESPACE
* TEST_HOST_URL * TEST_HOST_URL
* TEST_PRIVATE_TOKEN * TEST_PRIVATE_TOKEN
* *
* If any of the above are NULL, all tests in this class will be skipped. * If any of the above are NULL, all tests in this class will be skipped.
*/ */
@Category(IntegrationTest.class) @Category(IntegrationTest.class)
...@@ -76,7 +76,7 @@ public class TestGitLabApiException extends AbstractIntegrationTest { ...@@ -76,7 +76,7 @@ public class TestGitLabApiException extends AbstractIntegrationTest {
public void testNotFoundError() throws GitLabApiException { public void testNotFoundError() throws GitLabApiException {
try { try {
gitLabApi.getProjectApi().getProject(123456789); gitLabApi.getProjectApi().getProject(123456789L);
fail("GitLabApiException not thrown"); fail("GitLabApiException not thrown");
} catch (GitLabApiException gae) { } catch (GitLabApiException gae) {
assertFalse(gae.hasValidationErrors()); assertFalse(gae.hasValidationErrors());
......
...@@ -189,7 +189,7 @@ public class TestGroupApi extends AbstractIntegrationTest { ...@@ -189,7 +189,7 @@ public class TestGroupApi extends AbstractIntegrationTest {
assertTrue(optional.isPresent()); assertTrue(optional.isPresent());
assertEquals(testGroup.getId(), optional.get().getId()); assertEquals(testGroup.getId(), optional.get().getId());
optional = gitLabApi.getGroupApi().getOptionalGroup(12345); optional = gitLabApi.getGroupApi().getOptionalGroup(12345L);
assertNotNull(optional); assertNotNull(optional);
assertFalse(optional.isPresent()); assertFalse(optional.isPresent());
assertEquals(Response.Status.NOT_FOUND.getStatusCode(), GitLabApi.getOptionalException(optional).getHttpStatus()); assertEquals(Response.Status.NOT_FOUND.getStatusCode(), GitLabApi.getOptionalException(optional).getHttpStatus());
......
...@@ -39,28 +39,28 @@ public class TestIssueDiscussionsApi implements Constants { ...@@ -39,28 +39,28 @@ public class TestIssueDiscussionsApi implements Constants {
@Test @Test
public void testGetIssueDiscussionsByList() throws Exception { public void testGetIssueDiscussionsByList() throws Exception {
List<Discussion> discussions = new DiscussionsApi(gitLabApi).getIssueDiscussions(1, 1L); List<Discussion> discussions = new DiscussionsApi(gitLabApi).getIssueDiscussions(1L, 1L);
assertNotNull(discussions); assertNotNull(discussions);
assertTrue(compareJson(discussions, "issue-discussions.json")); assertTrue(compareJson(discussions, "issue-discussions.json"));
} }
@Test @Test
public void testGetIssueDiscussionsByListWithMaxItems() throws Exception { public void testGetIssueDiscussionsByListWithMaxItems() throws Exception {
List<Discussion> discussions = new DiscussionsApi(gitLabApi).getIssueDiscussions(1, 1L, 20); List<Discussion> discussions = new DiscussionsApi(gitLabApi).getIssueDiscussions(1L, 1L, 20);
assertNotNull(discussions); assertNotNull(discussions);
assertTrue(compareJson(discussions, "issue-discussions.json")); assertTrue(compareJson(discussions, "issue-discussions.json"));
} }
@Test @Test
public void testGetIssueDiscussionsByPager() throws Exception { public void testGetIssueDiscussionsByPager() throws Exception {
Pager<Discussion> discussions = new DiscussionsApi(gitLabApi).getIssueDiscussionsPager(1, 1L, 20); Pager<Discussion> discussions = new DiscussionsApi(gitLabApi).getIssueDiscussionsPager(1L, 1L, 20);
assertNotNull(discussions); assertNotNull(discussions);
assertTrue(compareJson(discussions.all(), "issue-discussions.json")); assertTrue(compareJson(discussions.all(), "issue-discussions.json"));
} }
@Test @Test
public void testGetIssueDiscussionsByStream() throws Exception { public void testGetIssueDiscussionsByStream() throws Exception {
Stream<Discussion> stream = new DiscussionsApi(gitLabApi).getIssueDiscussionsStream(1, 1L); Stream<Discussion> stream = new DiscussionsApi(gitLabApi).getIssueDiscussionsStream(1L, 1L);
assertNotNull(stream); assertNotNull(stream);
List<Discussion> discussions = stream.collect(Collectors.toList()); List<Discussion> discussions = stream.collect(Collectors.toList());
assertTrue(compareJson(discussions, "issue-discussions.json")); assertTrue(compareJson(discussions, "issue-discussions.json"));
......
...@@ -39,28 +39,28 @@ public class TestMergeRequestDiscussionsApi implements Constants { ...@@ -39,28 +39,28 @@ public class TestMergeRequestDiscussionsApi implements Constants {
@Test @Test
public void testGetMergeRequestDiscussionsByList() throws Exception { public void testGetMergeRequestDiscussionsByList() throws Exception {
List<Discussion> discussions = new DiscussionsApi(gitLabApi).getMergeRequestDiscussions(1, 1L); List<Discussion> discussions = new DiscussionsApi(gitLabApi).getMergeRequestDiscussions(1L, 1L);
assertNotNull(discussions); assertNotNull(discussions);
assertTrue(compareJson(discussions, "merge-request-discussions.json")); assertTrue(compareJson(discussions, "merge-request-discussions.json"));
} }
@Test @Test
public void testGetMergeRequestDiscussionsByListMaxItems() throws Exception { public void testGetMergeRequestDiscussionsByListMaxItems() throws Exception {
List<Discussion> discussions = new DiscussionsApi(gitLabApi).getMergeRequestDiscussions(1, 1L, 20); List<Discussion> discussions = new DiscussionsApi(gitLabApi).getMergeRequestDiscussions(1L, 1L, 20);
assertNotNull(discussions); assertNotNull(discussions);
assertTrue(compareJson(discussions, "merge-request-discussions.json")); assertTrue(compareJson(discussions, "merge-request-discussions.json"));
} }
@Test @Test
public void testGetMergeRequestDiscussionsByPager() throws Exception { public void testGetMergeRequestDiscussionsByPager() throws Exception {
Pager<Discussion> discussions = new DiscussionsApi(gitLabApi).getMergeRequestDiscussionsPager(1, 1L, 20); Pager<Discussion> discussions = new DiscussionsApi(gitLabApi).getMergeRequestDiscussionsPager(1L, 1L, 20);
assertNotNull(discussions); assertNotNull(discussions);
assertTrue(compareJson(discussions.all(), "merge-request-discussions.json")); assertTrue(compareJson(discussions.all(), "merge-request-discussions.json"));
} }
@Test @Test
public void testGetMergeRequestDiscussionsByStream() throws Exception { public void testGetMergeRequestDiscussionsByStream() throws Exception {
Stream<Discussion> stream = new DiscussionsApi(gitLabApi).getMergeRequestDiscussionsStream(1, 1L); Stream<Discussion> stream = new DiscussionsApi(gitLabApi).getMergeRequestDiscussionsStream(1L, 1L);
assertNotNull(stream); assertNotNull(stream);
List<Discussion> discussions = stream.collect(Collectors.toList()); List<Discussion> discussions = stream.collect(Collectors.toList());
assertTrue(compareJson(discussions, "merge-request-discussions.json")); assertTrue(compareJson(discussions, "merge-request-discussions.json"));
......
...@@ -40,8 +40,6 @@ public class TestPackageApi extends AbstractIntegrationTest { ...@@ -40,8 +40,6 @@ public class TestPackageApi extends AbstractIntegrationTest {
.withOrderBy(Constants.PackageOrderBy.CREATED_AT) .withOrderBy(Constants.PackageOrderBy.CREATED_AT)
.withSortOder(Constants.SortOrder.DESC); .withSortOder(Constants.SortOrder.DESC);
Optional<Package> lastPackage = packagesApi.getPackagesStream(testProject.getId(),filter).findAny(); Optional<Package> lastPackage = packagesApi.getPackagesStream(testProject.getId(),filter).findAny();
assertTrue(lastPackage.isPresent()); assertTrue(lastPackage.isPresent());
......
...@@ -638,7 +638,7 @@ public class TestProjectApi extends AbstractIntegrationTest { ...@@ -638,7 +638,7 @@ public class TestProjectApi extends AbstractIntegrationTest {
assertFalse(optional.isPresent()); assertFalse(optional.isPresent());
assertEquals(Response.Status.NOT_FOUND.getStatusCode(), GitLabApi.getOptionalException(optional).getHttpStatus()); assertEquals(Response.Status.NOT_FOUND.getStatusCode(), GitLabApi.getOptionalException(optional).getHttpStatus());
optional = gitLabApi.getProjectApi().getOptionalProject(1234567); optional = gitLabApi.getProjectApi().getOptionalProject(1234567L);
assertNotNull(optional); assertNotNull(optional);
assertFalse(optional.isPresent()); assertFalse(optional.isPresent());
assertEquals(Response.Status.NOT_FOUND.getStatusCode(), GitLabApi.getOptionalException(optional).getHttpStatus()); assertEquals(Response.Status.NOT_FOUND.getStatusCode(), GitLabApi.getOptionalException(optional).getHttpStatus());
......
...@@ -5,6 +5,7 @@ import org.gitlab4j.api.models.IssueEvent; ...@@ -5,6 +5,7 @@ import org.gitlab4j.api.models.IssueEvent;
import org.gitlab4j.api.models.Project; import org.gitlab4j.api.models.Project;
import org.junit.AfterClass; import org.junit.AfterClass;
import org.junit.BeforeClass; import org.junit.BeforeClass;
import org.junit.Ignore;
import org.junit.Test; import org.junit.Test;
import org.junit.experimental.categories.Category; import org.junit.experimental.categories.Category;
...@@ -37,6 +38,7 @@ public class TestResourceStateEventsApi extends AbstractIntegrationTest { ...@@ -37,6 +38,7 @@ public class TestResourceStateEventsApi extends AbstractIntegrationTest {
deleteAllTestIssues(); deleteAllTestIssues();
} }
@Ignore("should be enabled when CI tests will be run against GitLab 13.2+")
@Test @Test
public void testGetCloseReopenIssueEvents() throws GitLabApiException { public void testGetCloseReopenIssueEvents() throws GitLabApiException {
Long projectId = testProject.getId(); Long projectId = testProject.getId();
......
...@@ -39,28 +39,28 @@ public class TestSnippetDiscussionsApi implements Constants { ...@@ -39,28 +39,28 @@ public class TestSnippetDiscussionsApi implements Constants {
@Test @Test
public void testGetSnippetDiscussionsByList() throws Exception { public void testGetSnippetDiscussionsByList() throws Exception {
List<Discussion> discussions = new DiscussionsApi(gitLabApi).getSnippetDiscussions(1, 1L); List<Discussion> discussions = new DiscussionsApi(gitLabApi).getSnippetDiscussions(1L, 1L);
assertNotNull(discussions); assertNotNull(discussions);
assertTrue(compareJson(discussions, "snippet-discussions.json")); assertTrue(compareJson(discussions, "snippet-discussions.json"));
} }
@Test @Test
public void testGetSnippetDiscussionsByListWithMaxItems() throws Exception { public void testGetSnippetDiscussionsByListWithMaxItems() throws Exception {
List<Discussion> discussions = new DiscussionsApi(gitLabApi).getSnippetDiscussions(1, 1L, 20); List<Discussion> discussions = new DiscussionsApi(gitLabApi).getSnippetDiscussions(1L, 1L, 20);
assertNotNull(discussions); assertNotNull(discussions);
assertTrue(compareJson(discussions, "snippet-discussions.json")); assertTrue(compareJson(discussions, "snippet-discussions.json"));
} }
@Test @Test
public void testGetSnippetDiscussionsByPager() throws Exception { public void testGetSnippetDiscussionsByPager() throws Exception {
Pager<Discussion> discussions = new DiscussionsApi(gitLabApi).getSnippetDiscussionsPager(1, 1L, 20); Pager<Discussion> discussions = new DiscussionsApi(gitLabApi).getSnippetDiscussionsPager(1L, 1L, 20);
assertNotNull(discussions); assertNotNull(discussions);
assertTrue(compareJson(discussions.all(), "snippet-discussions.json")); assertTrue(compareJson(discussions.all(), "snippet-discussions.json"));
} }
@Test @Test
public void testGetSnippetDiscussionsByStream() throws Exception { public void testGetSnippetDiscussionsByStream() throws Exception {
Stream<Discussion> stream = new DiscussionsApi(gitLabApi).getSnippetDiscussionsStream(1, 1L); Stream<Discussion> stream = new DiscussionsApi(gitLabApi).getSnippetDiscussionsStream(1L, 1L);
assertNotNull(stream); assertNotNull(stream);
List<Discussion> discussions = stream.collect(Collectors.toList()); List<Discussion> discussions = stream.collect(Collectors.toList());
assertTrue(compareJson(discussions, "snippet-discussions.json")); assertTrue(compareJson(discussions, "snippet-discussions.json"));
......
...@@ -39,14 +39,14 @@ public class TestUnitMergeRequestApi { ...@@ -39,14 +39,14 @@ public class TestUnitMergeRequestApi {
@Test @Test
public void whenAllArgumentsNull_thenNoAttributesSent() throws Exception { public void whenAllArgumentsNull_thenNoAttributesSent() throws Exception {
new MergeRequestApi(mockGitLabApi).updateMergeRequest(1, 2L, null, null, null, null, null, null, new MergeRequestApi(mockGitLabApi).updateMergeRequest(1L, 2L, null, null, null, null, null, null,
null, null, null, null, null); null, null, null, null, null);
assertEquals(0, attributeCaptor.getValue().size()); assertEquals(0, attributeCaptor.getValue().size());
} }
@Test @Test
public void falseBooleansAreSerializedCorrectly() throws Exception { public void falseBooleansAreSerializedCorrectly() throws Exception {
new MergeRequestApi(mockGitLabApi).updateMergeRequest(1, 2L, null, null, null, null, null, null, new MergeRequestApi(mockGitLabApi).updateMergeRequest(1L, 2L, null, null, null, null, null, null,
null, null, null, null, false); null, null, null, null, false);
assertThat(attributeCaptor.getValue(), assertThat(attributeCaptor.getValue(),
hasEntry("allow_collaboration", Collections.singletonList("false"))); hasEntry("allow_collaboration", Collections.singletonList("false")));
...@@ -54,7 +54,7 @@ public class TestUnitMergeRequestApi { ...@@ -54,7 +54,7 @@ public class TestUnitMergeRequestApi {
@Test @Test
public void trueBooleansAreSerializedCorrectly() throws Exception { public void trueBooleansAreSerializedCorrectly() throws Exception {
new MergeRequestApi(mockGitLabApi).updateMergeRequest(1, 2L, null, null, null, null, null, null, new MergeRequestApi(mockGitLabApi).updateMergeRequest(1L, 2L, null, null, null, null, null, null,
null, null, null, null, true); null, null, null, null, true);
assertThat(attributeCaptor.getValue(), assertThat(attributeCaptor.getValue(),
hasEntry("allow_collaboration", Collections.singletonList("true"))); hasEntry("allow_collaboration", Collections.singletonList("true")));
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment