From d0d2cf0391a3c194787e2e9dde2e2fa637c008c1 Mon Sep 17 00:00:00 2001
From: Greg Messner <greg@messners.com>
Date: Fri, 14 Dec 2018 16:14:18 -0800
Subject: [PATCH] Added test for getting all discussions by list (#279).

---
 .../java/org/gitlab4j/api/TestCommitDiscussionsApi.java    | 7 +++++++
 src/test/java/org/gitlab4j/api/TestEpicDiscussionsApi.java | 7 +++++++
 .../java/org/gitlab4j/api/TestIssueDiscussionsApi.java     | 7 +++++++
 .../org/gitlab4j/api/TestMergeRequestDiscussionsApi.java   | 7 +++++++
 .../java/org/gitlab4j/api/TestSnippetDiscussionsApi.java   | 7 +++++++
 5 files changed, 35 insertions(+)

diff --git a/src/test/java/org/gitlab4j/api/TestCommitDiscussionsApi.java b/src/test/java/org/gitlab4j/api/TestCommitDiscussionsApi.java
index df70af40..fed14edb 100644
--- a/src/test/java/org/gitlab4j/api/TestCommitDiscussionsApi.java
+++ b/src/test/java/org/gitlab4j/api/TestCommitDiscussionsApi.java
@@ -40,6 +40,13 @@ public class TestCommitDiscussionsApi implements Constants {
 
     @Test
     public void testGetCommitDiscussionsByList() throws Exception {
+        List<Discussion> discussions = new DiscussionsApi(gitLabApi).getCommitDiscussions(1, 1);        
+        assertNotNull(discussions);
+        assertTrue(compareJson(discussions, "commit-discussions.json"));
+    }
+
+    @Test
+    public void testGetCommitDiscussionsByListWithMaxItems() throws Exception {
         List<Discussion> discussions = new DiscussionsApi(gitLabApi).getCommitDiscussions(1, 1, 20);        
         assertNotNull(discussions);
         assertTrue(compareJson(discussions, "commit-discussions.json"));
diff --git a/src/test/java/org/gitlab4j/api/TestEpicDiscussionsApi.java b/src/test/java/org/gitlab4j/api/TestEpicDiscussionsApi.java
index 10da7586..25344dbe 100644
--- a/src/test/java/org/gitlab4j/api/TestEpicDiscussionsApi.java
+++ b/src/test/java/org/gitlab4j/api/TestEpicDiscussionsApi.java
@@ -40,6 +40,13 @@ public class TestEpicDiscussionsApi implements Constants {
 
     @Test
     public void testGetEpicDiscussionsByList() throws Exception {
+        List<Discussion> discussions = new DiscussionsApi(gitLabApi).getEpicDiscussions(1, 1);        
+        assertNotNull(discussions);
+        assertTrue(compareJson(discussions, "epic-discussions.json"));
+    }
+
+    @Test
+    public void testGetEpicDiscussionsByListWithMaxItems() throws Exception {
         List<Discussion> discussions = new DiscussionsApi(gitLabApi).getEpicDiscussions(1, 1, 20);        
         assertNotNull(discussions);
         assertTrue(compareJson(discussions, "epic-discussions.json"));
diff --git a/src/test/java/org/gitlab4j/api/TestIssueDiscussionsApi.java b/src/test/java/org/gitlab4j/api/TestIssueDiscussionsApi.java
index 25f87ea9..ec45cf0d 100644
--- a/src/test/java/org/gitlab4j/api/TestIssueDiscussionsApi.java
+++ b/src/test/java/org/gitlab4j/api/TestIssueDiscussionsApi.java
@@ -40,6 +40,13 @@ public class TestIssueDiscussionsApi implements Constants {
 
     @Test
     public void testGetIssueDiscussionsByList() throws Exception {
+        List<Discussion> discussions = new DiscussionsApi(gitLabApi).getIssueDiscussions(1, 1);        
+        assertNotNull(discussions);
+        assertTrue(compareJson(discussions, "issue-discussions.json"));
+    }
+
+    @Test
+    public void testGetIssueDiscussionsByListWithMaxItems() throws Exception {
         List<Discussion> discussions = new DiscussionsApi(gitLabApi).getIssueDiscussions(1, 1, 20);        
         assertNotNull(discussions);
         assertTrue(compareJson(discussions, "issue-discussions.json"));
diff --git a/src/test/java/org/gitlab4j/api/TestMergeRequestDiscussionsApi.java b/src/test/java/org/gitlab4j/api/TestMergeRequestDiscussionsApi.java
index 73ded134..8a2659a5 100644
--- a/src/test/java/org/gitlab4j/api/TestMergeRequestDiscussionsApi.java
+++ b/src/test/java/org/gitlab4j/api/TestMergeRequestDiscussionsApi.java
@@ -40,6 +40,13 @@ public class TestMergeRequestDiscussionsApi implements Constants {
 
     @Test
     public void testGetMergeRequestDiscussionsByList() throws Exception {
+        List<Discussion> discussions = new DiscussionsApi(gitLabApi).getMergeRequestDiscussions(1, 1);        
+        assertNotNull(discussions);
+        assertTrue(compareJson(discussions, "merge-request-discussions.json"));
+    }
+
+    @Test
+    public void testGetMergeRequestDiscussionsByListMaxItems() throws Exception {
         List<Discussion> discussions = new DiscussionsApi(gitLabApi).getMergeRequestDiscussions(1, 1, 20);        
         assertNotNull(discussions);
         assertTrue(compareJson(discussions, "merge-request-discussions.json"));
diff --git a/src/test/java/org/gitlab4j/api/TestSnippetDiscussionsApi.java b/src/test/java/org/gitlab4j/api/TestSnippetDiscussionsApi.java
index f8d111f6..8ef03fa0 100644
--- a/src/test/java/org/gitlab4j/api/TestSnippetDiscussionsApi.java
+++ b/src/test/java/org/gitlab4j/api/TestSnippetDiscussionsApi.java
@@ -40,6 +40,13 @@ public class TestSnippetDiscussionsApi implements Constants {
 
     @Test
     public void testGetSnippetDiscussionsByList() throws Exception {
+        List<Discussion> discussions = new DiscussionsApi(gitLabApi).getSnippetDiscussions(1, 1);        
+        assertNotNull(discussions);
+        assertTrue(compareJson(discussions, "snippet-discussions.json"));
+    }
+
+    @Test
+    public void testGetSnippetDiscussionsByListWithMaxItems() throws Exception {
         List<Discussion> discussions = new DiscussionsApi(gitLabApi).getSnippetDiscussions(1, 1, 20);        
         assertNotNull(discussions);
         assertTrue(compareJson(discussions, "snippet-discussions.json"));
-- 
GitLab